Skip to content

Fix reviewdog arguments #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −7
Draft

Fix reviewdog arguments #2157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e48e6a7
Deprecate ConfigFile.DockerVersion field
Subserial Nov 13, 2025
d54edff
Fix lint error
Subserial Nov 13, 2025
a3d3c2d
Fix reviewdog arguments
Subserial Nov 13, 2025
0372152
Make first step to understanding the action being used
Subserial Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/style.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,4 @@ jobs:
github-token: ${{ secrets.github_token }}
reporter: github-pr-check
level: error
fail-on-error: true
reviewdog-flags: "--fail-level=error"
1 change: 1 addition & 0 deletions pkg/v1/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// Copyright 2018 Google LLC All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -27,10 +27,11 @@
// docker_version and os.version are not part of the spec but included
// for backwards compatibility.
type ConfigFile struct {
Architecture string `json:"architecture"`

Check failure on line 30 in pkg/v1/config.go

View workflow job for this annotation

GitHub Actions / Lint 

File is not properly formatted (gofmt)
Author string `json:"author,omitempty"`
Container string `json:"container,omitempty"`
Created Time `json:"created,omitempty"`
// Deprecated: original field was removed upstream
DockerVersion string `json:"docker_version,omitempty"`
History []History `json:"history,omitempty"`
OS string `json:"os"`
Expand Down
11 changes: 5 additions & 6 deletions pkg/v1/daemon/image.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,12 +283,11 @@ func (i *image) computeConfigFile(inspect api.InspectResponse) (*v1.ConfigFile,
}

return &v1.ConfigFile{
Architecture: inspect.Architecture,
Author: inspect.Author,
Created: v1.Time{Time: created},
DockerVersion: inspect.DockerVersion,
History: history,
OS: inspect.Os,
Architecture: inspect.Architecture,
Author: inspect.Author,
Created: v1.Time{Time: created},
History: history,
OS: inspect.Os,
RootFS: v1.RootFS{
Type: inspect.RootFS.Type,
DiffIDs: diffIDs,
Expand Down
Loading