Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire: use multiline instead of one single line for errors with traces #571

Merged
merged 3 commits into from
Oct 25, 2018
Merged

wire: use multiline instead of one single line for errors with traces #571

merged 3 commits into from
Oct 25, 2018

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Oct 25, 2018

Fixes #570 .

@vangent vangent requested a review from zombiezen October 25, 2018 16:24
@googlebot googlebot added the cla: yes Google CLA has been signed! label Oct 25, 2018
zombiezen
zombiezen approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@zombiezen zombiezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zombiezen zombiezen assigned vangent and unassigned zombiezen Oct 25, 2018
@zombiezen
Copy link
Contributor

Spelling error in commit message? I would merge in, but I'm not sure what you meant to say.

@vangent vangent changed the title wire: use multiline instead of one single line for errors with trackes wire: use multiline instead of one single line for errors with traces Oct 25, 2018
@vangent
Copy link
Contributor Author

vangent commented Oct 25, 2018

oops, yes -- trackes --> traces

@vangent vangent merged commit 77aed93 into google:master Oct 25, 2018
@vangent vangent deleted the multiline branch October 25, 2018 17:33
zombiezen pushed a commit to google/wire that referenced this pull request Nov 28, 2018
@vangent @zombiezen
wire: use multiline errors instead of one single line for errors with…
b7c4e8d 
… traces (google/go-cloud#571)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombiezen zombiezen zombiezen approved these changes

Assignees

@vangent vangent

Labels
cla: yes Google CLA has been signed!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vangent @zombiezen @googlebot