Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub/awssnssqs: Use PublishBatch for sending messages in SNS #3288

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Jul 31, 2023

Fixes #3285.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #3288 (6a4e843) into master (7b6de3c) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 88.18%.

❗ Current head 6a4e843 differs from pull request most recent head a9e9a6d. Consider uploading reports for the commit a9e9a6d to get more accurate results

@@            Coverage Diff             @@
##           master    #3288      +/-   ##
==========================================
+ Coverage   77.41%   77.43%   +0.02%     
==========================================
  Files         104      104              
  Lines       13855    13908      +53     
==========================================
+ Hits        10726    10770      +44     
- Misses       2373     2378       +5     
- Partials      756      760       +4     
Files Changed Coverage Δ
pubsub/awssnssqs/awssnssqs.go 84.75% <88.07%> (+0.64%) ⬆️
blob/fileblob/fileblob.go 82.09% <100.00%> (ø)

... and 2 files with indirect coverage changes

@vangent vangent merged commit e6e3a0e into google:master Jul 31, 2023
4 checks passed
@vangent vangent deleted the awsbatch branch July 31, 2023 22:48
ybourgery pushed a commit to Simprints/go-cloud that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub/awssnssqs: Support SNS:PublishBatch in SendBatch for SNS Topic
1 participant