Skip to content

Conversation

@leezen
Copy link

@leezen leezen commented Apr 16, 2021

Fixes #2982

Providing an empty map ends up causing the underlying SDK to want to have permissions to write tags against the destination blob. However, we don't actually need this permission since we're not really writing any tags. Instead, we should just pass in nil.

@google-cla
Copy link

google-cla bot commented Apr 16, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Cannot accept contribution until Google CLA is signed. label Apr 16, 2021
}
}
resp, err := dstBlobURL.StartCopyFromURL(ctx, srcURL, md, mac, bac, at, btm)
resp, err := dstBlobURL.StartCopyFromURL(ctx, srcURL, md, mac, bac, at, nil /* blogsTagMap */)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: BlobTagsMap (typo)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, not sure how I mistyped that. Guess I must be thinking about blogs...

@vangent
Copy link
Contributor

vangent commented Apr 16, 2021

Hmm this looks like it's a change to the golden file, which is hard for you to do. If you don't mind I'll clone it and send it to you.

@vangent
Copy link
Contributor

vangent commented Apr 16, 2021

Cloned into #2989.

@vangent vangent closed this Apr 16, 2021
@leezen
Copy link
Author

leezen commented Apr 16, 2021

@vangent Sounds good.

@pulumi-bot pulumi-bot deleted the leezen/azure-copy-notags branch April 16, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no Cannot accept contribution until Google CLA is signed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

blob/azblob: Permissions error when using SAS Token

2 participants