Skip to content

docstore/memdocstore: apply limit after sorting #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2021
Merged

docstore/memdocstore: apply limit after sorting #2978

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
302c5a1
docstore/memdocstore: apply limit after sorting
jba Mar 16, 2021
3740d9e
Merge branch 'master' into fix-memdocstore
vangent Mar 16, 2021
59d2e60
re-run CI
jba Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions docstore/memdocstore/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,18 @@ func (c *collection) RunGetQuery(_ context.Context, q *driver.Query) (driver.Doc

var resultDocs []storedDoc
for _, doc := range c.docs {
if q.Limit > 0 && len(resultDocs) == q.Limit {
break
}
if filtersMatch(q.Filters, doc) {
resultDocs = append(resultDocs, doc)
}
}
if q.OrderByField != "" {
sortDocs(resultDocs, q.OrderByField, q.OrderAscending)
}

if q.Limit > 0 && len(resultDocs) > q.Limit {
resultDocs = resultDocs[:q.Limit]
}

// Include the key field in the field paths if there is one.
var fps [][]string
if len(q.FieldPaths) > 0 && c.keyField != "" {
Expand Down