Fix(attributecert): Use int64 for ComponentManufacturerID #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ComponentManufacturerID field in the ComponentIdentifierV1 and ComponentIdentifierV2 structs was an 'int', which is only 32 bits on 32-bit architectures. This caused an "integer too large" error when parsing a certificate with a manufacturer ID that exceeded the maximum value for a 32-bit signed integer. This change fixes the issue by changing the type of the ComponentManufacturerID field to int64 in the Component, ComponentIdentifierV1, and ComponentIdentifierV2 structs. This ensures that the field has enough range to handle larger integer values on all architectures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ComponentManufacturerID field in the ComponentIdentifierV1 and ComponentIdentifierV2 structs was an 'int', which is only 32 bits on 32-bit architectures. This caused an "integer too large" error when parsing a certificate with a manufacturer ID that exceeded the maximum value for a 32-bit signed integer.
This change fixes the issue by changing the type of the ComponentManufacturerID field to int64 in the Component, ComponentIdentifierV1, and ComponentIdentifierV2 structs. This ensures that the field has enough range to handle larger integer values on all architectures.
Fixes #439