wip: rust cli #185
Draft
wip: rust cli #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generally looks good to me. I have nothing to add to your TODOs. Thanks! :) |
burgerdev
commented
Oct 30, 2024
| name = "glome" | ||
| path = "src/cli/bin.rs" | ||
|
|
||
| required-features = ["cli"] |
There was a problem hiding this comment.
Document what this does.
| use std::fs; | ||
| use std::io::{self, Read, Write}; | ||
| use std::path::PathBuf; | ||
| use x25519_dalek::{PublicKey, StaticSecret}; |
There was a problem hiding this comment.
Can we make this crypto-lib-agnostic?
| if handshake.len() < 33 { | ||
| panic!("handshake too short") // TODO(burgerdev): better error output | ||
| } | ||
| let _message_tag_suffix = handshake.split_off(33); |
testable subcommands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First impression of a concise Rust implementation of the CLI - turned out I had this sitting on an abandoned branch.