DCHECK_ALWAYS_ON to make D* enabled under NDEBUG #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukai
reviewed
Feb 8, 2017
src/glog/logging.h.in
Outdated
| @@ -986,7 +992,7 @@ const LogSeverity GLOG_0 = GLOG_ERROR; | |||
| LOG_IF_EVERY_N(severity, condition, n) | |||
| #define DLOG_ASSERT(condition) LOG_ASSERT(condition) | |||
|
|
|||
| // debug-only checking. not executed in NDEBUG mode. | |||
| // debug-only checking. not executed in DCHECK_IS_ON() mode. | |||
There was a problem hiding this comment.
not executed in !DCHECK_IS_ON() mode?
ukai
reviewed
Feb 8, 2017
src/windows/glog/logging.h
Outdated
| @@ -990,7 +996,7 @@ const LogSeverity GLOG_0 = GLOG_ERROR; | |||
| LOG_IF_EVERY_N(severity, condition, n) | |||
| #define DLOG_ASSERT(condition) LOG_ASSERT(condition) | |||
|
|
|||
| // debug-only checking. not executed in NDEBUG mode. | |||
| // debug-only checking. not executed in DCHECK_IS_ON() mode. | |||
There was a problem hiding this comment.
not executed in !DCHECK_IS_ON() mode.
The macro NDEBUG could be automatically defined for release build on some build environments (e.g. MSVC). If we use NDEBUG as a key to distinguish using DCHECK as CHECK (I call this DCHECK is enabled) or not, we cannot make DCHECK enabled for release build on such environments. Considering people use a program with glog for presubmit testing or dogfooding, they should need to do release build with DCHECK enabled.
yoshisatoyanagisawa
force-pushed
the
dcheck_always_on
branch
from
5534cf9 to
027332f
Compare
|
Good catch! |
ukai
approved these changes
Feb 9, 2017
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
DCHECK_ALWAYS_ON to make D* enabled under NDEBUG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro NDEBUG could be automatically defined for release build on
some build environments (e.g. MSVC). If we use NDEBUG as a key to
distinguish using DCHECK as CHECK (I call this DCHECK is enabled) or
not, we cannot make DCHECK enabled for release build on such
environments.
Considering people use a program with glog for presubmit testing or
dogfooding, they should need to do release build with DCHECK enabled.