Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment NOTE about SetVLOGLevel #1109

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix comment NOTE about SetVLOGLevel #1109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e258ca
Fix NOTE about SetVLOGLevel
hari90 Jun 21, 2024
95d017a
Remove then
hari90 Jun 24, 2024
4a40e5e
Update docs
hari90 Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/logging.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,9 +247,11 @@ The wildcarding functionality 3. supports both `*` (matches 0 or more
characters) and `?` (matches any single character) wildcards. Please also refer
to [command line flags](flags.md) for more information.

You can dynamically control the level of a module using the `#!cpp SetVLOGLevel` function.

There's also `#!cpp VLOG_IS_ON(n)` "verbose level" condition macro. This macro
returns `#!cpp true` when the `--v` is equal to or greater than `n`. The macro can be
used as follows:
returns `#!cpp true` when the matching `--vmodule`, else `--v` is equal to or greater than `n`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description seems to be broken now. The else part looks out of place. What am I missing?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to convey the fact that if there is no matching --vmodule then --v is used. Should we just change it to "when the level is equal to or greater than"?

The macro can be used as follows:

``` cpp
if (VLOG_IS_ON(2)) {
Expand Down
8 changes: 3 additions & 5 deletions src/glog/vlog_is_on.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,9 @@ namespace google {
// Set VLOG(_IS_ON) level for module_pattern to log_level.
// This lets us dynamically control what is normally set by the --vmodule flag.
// Returns the level that previously applied to module_pattern.
// NOTE: To change the log level for VLOG(_IS_ON) sites
// that have already executed after/during InitGoogleLogging,
// one needs to supply the exact --vmodule pattern that applied to them.
// (If no --vmodule pattern applied to them
// the value of FLAGS_v will continue to control them.)
// NOTE: All VLOG(_IS_ON) sites that have not matched any prior module_patterns
// will be re-evaluated with the provided module_pattern. Sites that have
// already matched a different module_pattern will not be affected.
extern GLOG_EXPORT int SetVLOGLevel(const char* module_pattern, int log_level);

// Various declarations needed for VLOG_IS_ON above: =========================
Expand Down