Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to Bzlmod usage #1099

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Conversation

Vertexwahn
Copy link
Contributor

Update README to Bzlmod usage

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.04%. Comparing base (45f99f5) to head (3d61ef6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1099      +/-   ##
==========================================
+ Coverage   63.57%   64.04%   +0.46%     
==========================================
  Files          20       20              
  Lines        2578     2578              
  Branches      894      891       -3     
==========================================
+ Hits         1639     1651      +12     
+ Misses        671      662       -9     
+ Partials      268      265       -3     

see 2 files with indirect coverage changes

@Vertexwahn
Copy link
Contributor Author

Vertexwahn commented Jun 9, 2024

@sergiud I forgot to update the documentation - this PR updates the docs according to the merged change #1097

@sergiud sergiud self-assigned this Jun 9, 2024
@sergiud sergiud added this to the 0.8 milestone Jun 9, 2024
@sergiud
Copy link
Collaborator

sergiud commented Jun 9, 2024

Thanks! I intend to merge your changes after #1101, which heavily reworks the documentation. Sorry for the inconvenience.

@sergiud
Copy link
Collaborator

sergiud commented Jun 11, 2024

@Vertexwahn You can go ahead and apply your changes on top of the mkdocs branch.

Copy link
Collaborator

@sergiud sergiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reworked documentation has been merged. Please rebase.

@sergiud sergiud removed this from the 0.8 milestone Jun 22, 2024
@Vertexwahn
Copy link
Contributor Author

Vertexwahn commented Jun 25, 2024

@sergiud Rebased my change

@Vertexwahn Vertexwahn requested a review from sergiud June 25, 2024 21:20
@sergiud
Copy link
Collaborator

sergiud commented Jul 7, 2024

Thank you!

@sergiud sergiud added this to the 0.8 milestone Jul 7, 2024
@sergiud sergiud merged commit 570c7e4 into google:master Jul 7, 2024
136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants