Skip to content

Use overload of lookupTarget accepting triple #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boomanaiden154 merged 1 commit into from
Oct 13, 2025
Merged

Use overload of lookupTarget accepting triple #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gematria/llvm/llvm_architecture_support.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ LlvmArchitectureSupport::FromTriple(std::string_view llvm_triple,
std::string lookup_error;
// TODO(ondrasej): Remove the std::string() conversion once it's no longer
// needed.
const llvm::Target* const llvm_target =
llvm::TargetRegistry::lookupTarget(llvm_triple, lookup_error);
const llvm::Target* const llvm_target = llvm::TargetRegistry::lookupTarget(
llvm::Triple(llvm::StringRef(llvm_triple)), lookup_error);
if (llvm_target == nullptr) {
return llvm::make_error<llvm::StringError>(
llvm::errc::not_supported,
Expand Down
4 changes: 2 additions & 2 deletions llvm_cm/tools/llvm-cm/llvm-cm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,9 +465,9 @@ int main(int argc, char *argv[]) {

// Start setting up the disassembler.
std::string Error;
const Target *TheTarget = TargetRegistry::lookupTarget(TripleName, Error);
exitIf(!TheTarget, Error);
llvm::Triple TargetTriple(TripleName);
const Target *TheTarget = TargetRegistry::lookupTarget(TargetTriple, Error);
exitIf(!TheTarget, Error);

std::unique_ptr<MCRegisterInfo> MRI(TheTarget->createMCRegInfo(TargetTriple));
assert(MRI && "Unable to create target register info!");
Expand Down
Loading