Replace X and Y in geometry view with matrix. #1224
Conversation
This allows unlimited rotation in both axes. Fixes google#1215
AWoloszyn
force-pushed
the
geometry-view
branch
from
f603971 to
82dcbdd
Compare
pmuetschard
left a comment
pmuetschard
left a comment
There was a problem hiding this comment.
I don't like it. I was going to say on the bug that its WAI, but I'm open to discussion.
The point of the cylinder camera model is to prevent rotation over the top/bottom as that would invert the horizontal drag. In Tom's case, all he has to do is press the z-up button and everything would look like the way he wants.
BTW, the only thing required to get rid of the limits is to remove the angleX = Math.min(Math.max(angleX, -90), 90); line.
|
As a note, this method doesn't invert the horizontal drag after rotating over the top/bottom. |
|
After consideration it's clear that different people prefer different camera modes. Can I suggest we add an option to the settings dialog for camera style? If we do that, can I also add my preferred camera style - WASD? |
3 participants
This allows unlimited rotation in both axes.
Fixes #1215