Skip to content

Conversation

@aaronbell
Copy link
Collaborator

@aaronbell aaronbell commented Nov 21, 2025

Updating the font with community-provided improvements (from @NightFurySL2001)

30 incorrect glyphs: 廊郡盟儒膈涎锴嗖恫劓巅遥害赜蒸逸榔隆窿榘撅诶嗳嫒嵫袱烙酪寇狰
7 contour problems: 腐蚯螓貘碡畿袜
68 shifted glyphs: 馇恽饪忾狲馔馀恻馄饨恺怃饩狍怄馑狯饷馓恸饽猬廪恹犷饧忏馍惬饬犸馐怆猡饴怿猕赓馊悭饫怅猃馕庑钛钌睐钚钊眦钕钋眍钗钇钫钔钆钤钐羁钣钏罴钜钍睑
Position and design of punctuations: 、。,:;!?
Add vert feature for vertical typesetting
Added 啰瞭〇.

Closes: #10005

30 incorrect glyphs: 廊郡盟儒膈涎锴嗖恫劓巅遥害赜蒸逸榔隆窿榘撅诶嗳嫒嵫袱烙酪寇狰
7 contour problems: 腐蚯螓貘碡畿袜
68 shifted glyphs: 馇恽饪忾狲馔馀恻馄饨恺怃饩狍怄馑狯饷馓恸饽猬廪恹犷饧忏馍惬饬犸馐怆猡饴怿猕赓馊悭饫怅猃馕庑钛钌睐钚钊眦钕钋眍钗钇钫钔钆钤钐羁钣钏罴钜钍睑
Position and design of punctuations: 、。,:;!?
Add vert feature for vertical typesetting
Added 啰瞭〇.
@github-actions
Copy link
Contributor

FontSpector report

fontspector version: 1.5.1

Check results

[18] ofl/zcoolkuaile/ZCOOLKuaiLe-Regular.ttf
🔥 FAIL Check family name for GF Guide compliance. (googlefonts/name/family_name_compliance)
  • 🔥 FAIL "ZCOOL KuaiLe" is a CamelCased name. To solve this, simply use spaces instead in the font name. [code: camelcase]

  • 🔥 FAIL "ZCOOL KuaiLe" contains an abbreviation. [code: abbreviation]

⚠️ WARN Does the font contain chws and vchw features? (cjk_chws_feature)
⚠️ WARN Check if each glyph has the recommended amount of contours. (contour_count)
  • ⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are
    inferred from the typical amounts of contours observed in a
    large collection of reference font families. The divergences
    listed below may simply indicate a significantly different
    design on some of your glyphs. On the other hand, some of these
    may flag actual bugs in the font such as glyphs mapped to an
    incorrect codepoint. Please consider reviewing the design and
    codepoint assignment of these to make sure they are correct.

    The following glyphs do not have the recommended number of contours:

  • uniFFE5 (U+FFE5): found 2, expected one of: {1, 3} [code: contour-count]
⚠️ WARN Ensure files are not too large. (file_size)
  • ⚠️ WARN Font file is 1.51 MB; ideally it should be less than 1.05 MB [code: large-font]
⚠️ WARN Does GPOS table have kerning information? (gpos_kerning_info)
  • ⚠️ WARN GPOS table lacks kerning information. [code: lacks-kern-info]
⚠️ WARN Check math signs have the same width. (math_signs_width)
  • ⚠️ WARN The most common width is 620 among a set of 9 math glyphs.
    The following math glyphs have a different width, though:
    width=460: less
    width=468: greater
    width=610: logicalnot
    width=535: multiply
    width=640: plusminus
    width=630: equal [code: width-outliers]
⚠️ WARN Ensure indic fonts have the Indian Rupee Sign glyph. (rupee)
  • ⚠️ WARN Font is missing the Indian Rupee Sign glyph. Please add a glyph for Indian Rupee Sign (₹) at codepoint U+20B9. [code: missing-rupee]
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
  • ⚠️ WARN The following separator glyphs are missing:
  • U+2028
  • U+2029 [code: missing-separator-glyphs]
⚠️ WARN Do outlines contain any jaggy segments? (outline_jaggy_segments)
  • ⚠️ WARN The following glyphs have jaggy segments:
  • uni4E25 (U+4E25): Line(Line { p0: (858.0, 699.0), p1: (648.0, 688.0) })/Line(Line { p0: (648.0, 688.0), p1: (650.0, 688.0) }) = 2.998467139694441
  • uni4F65 (U+4F65): Line(Line { p0: (488.0, 39.0), p1: (484.0, 38.0) })/Line(Line { p0: (484.0, 38.0), p1: (816.0, 52.0) }) = 11.621586947075693
  • uni4FEA (U+4FEA): Line(Line { p0: (411.0, 117.0), p1: (369.0, 244.0) })/Line(Line { p0: (369.0, 244.0), p1: (392.0, -48.0) }) = 13.795773064268515
  • uni4FEA (U+4FEA): Line(Line { p0: (751.0, 118.0), p1: (683.0, 346.0) })/Line(Line { p0: (683.0, 346.0), p1: (710.0, -48.0) }) = 12.686748955803381
  • uni50D6 (U+50D6): Line(Line { p0: (417.0, 297.0), p1: (483.0, 313.0) })/Line(Line { p0: (483.0, 313.0), p1: (418.0, 313.0) }) = 13.626994859891557
  • uni50F5 (U+50F5): Line(Line { p0: (525.0, 492.0), p1: (489.0, 487.0) })/Line(Line { p0: (489.0, 487.0), p1: (525.0, 488.0) }) = 6.316022431763846
  • uni5112 (U+5112): Line(Line { p0: (559.0, 547.0), p1: (441.0, 548.0) })/Line(Line { p0: (441.0, 548.0), p1: (550.0, 525.0) }) = 11.429601241256892
  • uni5121 (U+5121): Line(Line { p0: (565.0, 312.0), p1: (583.0, 32.0) })/Line(Line { p0: (583.0, 32.0), p1: (581.0, 325.0) }) = 3.2871473249363206
  • uni5180 (U+5180): Line(Line { p0: (68.0, 660.0), p1: (194.0, 677.0) })/Line(Line { p0: (194.0, 677.0), p1: (82.0, 689.0) }) = 13.799485396019334
    ... and 527 others [code: found-jaggy-segments]
⚠️ WARN Check there are no overlapping path segments (overlapping_path_segments)
  • ⚠️ WARN The following glyphs have overlapping path segments:
  • uni55F7 (U+55F7): Quad(QuadBez { p0: (678.0, 504.0), p1: (674.0, 503.0), p2: (678.0, 504.0) }) has the same coordinates as a previous segment.
  • uni91AD (U+91AD): Line(Line { p0: (825.0, 532.0), p1: (827.0, 537.0) }) has the same coordinates as a previous segment. [code: overlapping-path-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines? (outline_semi_vertical)
  • ⚠️ WARN The following glyphs have semi-vertical/semi-horizontal lines:
  • H (U+0048): Line(Line { p0: (598.0, 470.0), p1: (600.0, 704.0) })
  • H (U+0048): Line(Line { p0: (594.0, 16.0), p1: (597.0, 375.0) })
  • uniFF28 (U+FF28): Line(Line { p0: (679.0, 470.0), p1: (681.0, 704.0) })
  • uniFF28 (U+FF28): Line(Line { p0: (675.0, 16.0), p1: (678.0, 375.0) })
  • m (U+006D): Line(Line { p0: (409.0, 358.0), p1: (411.0, 42.0) })
  • uniFF4D (U+FF4D): Line(Line { p0: (515.0, 358.0), p1: (517.0, 42.0) })
  • uni4E1D (U+4E1D): Line(Line { p0: (882.0, -44.0), p1: (38.0, -39.0) })
  • uni4E1D (U+4E1D): Line(Line { p0: (39.0, 56.0), p1: (882.0, 49.0) })
  • uni4E2C (U+4E2C): Line(Line { p0: (575.0, -46.0), p1: (573.0, 246.0) })
    ... and 4751 others [code: found-semi-vertical]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
  • ⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID. (googlefonts/vendor_id)
  • ⚠️ WARN OS/2 VendorID value 'ZYEC' is not yet recognized.
    If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
  • ℹ️ INFO The family name "ZCOOL KuaiLe" seems to be already in use.
    Please visit http://namecheck.fontdata.com/ for more info. [code: name-collision]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
  • ℹ️ INFO Hinting filesize impact:
ZCOOLKuaiLe-Regular.ttf
Dehinted Size 1514808
Hinted Size 1514832
Increase 24
Change 0.0 %
ℹ️ INFO Font contains all required tables? (required_tables)
  • ℹ️ INFO This font contains the following optional tables:

    loca
    prep
    GSUB
    gasp [code: optional-tables]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
  • ℹ️ INFO These are the ppm ranges declared on the gasp table:

| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |

- Use smoothing along multiple axes with ClearType®
[code: ranges]
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
  • ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 2.001 [code: version-not-detected]
[2] ofl/zcoolkuaile/METADATA.pb
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (googlefonts/metadata/designer_profiles)
  • ⚠️ WARN It seems that liubingke is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]

  • ⚠️ WARN It seems that yangkang is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]

  • ⚠️ WARN It seems that wushaojie is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]

ℹ️ INFO Check METADATA.pb parses correctly (googlefonts/metadata/validate)
  • ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
[1] ofl/zcoolkuaile/DESCRIPTION.en_us.html
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
  • 🔥 FAIL Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file. [code: lacks-git-url]
[7] ofl/zcoolkuaile
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field. (googlefonts/metadata/consistent_repo_urls)
🔥 FAIL Check Google Fonts glyph coverage. (googlefonts/glyph_coverage)
  • 🔥 FAIL ofl/zcoolkuaile/ZCOOLKuaiLe-Regular.ttf missing required codepoints:
  • 0x00AE: REGISTERED SIGN [code: missing-codepoints]
⚠️ WARN METADATA.pb: Check for primary_script (googlefonts/metadata/primary_script)
  • ⚠️ WARN METADATA.pb: primary_script is 'Hans' but should be 'Hani'. [code: wrong-primary-script]
⚠️ WARN METADATA.pb subsets are correct? (googlefonts/metadata/subsets_correct)
  • ⚠️ WARN Please add 'chinese-hongkong' to METADATA.pb since more than 50% of its glyphs are supported by this font file. [code: missing-subset]

  • ⚠️ WARN Please add 'chinese-traditional' to METADATA.pb since more than 50% of its glyphs are supported by this font file. [code: missing-subset]

  • ⚠️ WARN Please add 'japanese' to METADATA.pb since more than 50% of its glyphs are supported by this font file. [code: missing-subset]

⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
  • ⚠️ WARN ofl/zcoolkuaile/ZCOOLKuaiLe-Regular.ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
  • U+02C7 CARON: try adding one of: canadian-aboriginal, yi, tifinagh, latin-ext
  • U+2015 HORIZONTAL BAR: try adding adlam
  • U+2025 TWO DOT LEADER: try adding phags-pa
  • U+2030 PER MILLE SIGN: try adding adlam
  • U+4E2C CJK UNIFIED IDEOGRAPH-4E2C: try adding chinese-hongkong
  • U+4EA0 CJK UNIFIED IDEOGRAPH-4EA0: try adding japanese
  • U+4EC2 CJK UNIFIED IDEOGRAPH-4EC2: try adding japanese
  • U+4F7E CJK UNIFIED IDEOGRAPH-4F7E: try adding one of: chinese-hongkong, chinese-traditional
  • U+5025 CJK UNIFIED IDEOGRAPH-5025: try adding japanese
    ... and 289 others

Or you can add the above codepoints to one of the subsets supported by the font: chinese-simplified, latin, menu [code: unreachable-subsetting]

ℹ️ INFO Check for presence of an ARTICLE.en_us.html file (googlefonts/description/has_article)
  • ℹ️ INFO This font doesn't have an ARTICLE.en_us.html file. [code: missing-article]
ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
  • ℹ️ INFO All of the fonts lack a STAT table. [code: summary]

Summary

🔥 FAIL ⚠️ WARN ℹ️ INFO ✅ PASS ⏩ SKIP
5 21 8 111 62
2% 10% 4% 56% 31%

@emmamarichal
Copy link
Collaborator

@aaronbell

  • 🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field. (googlefonts/metadata/consistent_repo_urls)
    -> Ok to ignore, but if we want to avoid fails, we just need to remove "www" from the url in copyrights and OFL. (but it means to update it in sources
  • 🔥 FAIL Check Google Fonts glyph coverage. (googlefonts/glyph_coverage)
    -> Same, ok to ignore, but if you re-open the source file, you can add the registered symbol to avoid that fail.
  • ⚠️ WARN METADATA.pb: Check for primary_script (googlefonts/metadata/primary_script)
  • ⚠️ WARN METADATA.pb subsets are correct? (googlefonts/metadata/subsets_correct)
    -> Everything is correct in metadata.pb? (primary script + substets)
  • ⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (googlefonts/metadata/designer_profiles)
    -> Let me know if you need the form to send to designers (so I can add them to the catalog)

OFL / Description

  • 🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
    -> You can add: <p>To contribute, see <a href="/googlefonts/zcool-kuaile">github.com/googlefonts/zcool-kuaile</a>.</p>
  • Update OFL url in the licence: https://openfontlicense.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I Font Upgrade I Small Fix bugs fixed but nothing added

Projects

Status: PR GF

Development

Successfully merging this pull request may close these issues.

Update ZCOOL KuaiLe

2 participants