Skip to content

Support headless mode #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 16, 2020
Merged

Support headless mode #760

merged 4 commits into from
Jun 16, 2020

Conversation

robert-ancell
Copy link
Collaborator

@robert-ancell robert-ancell commented Jun 14, 2020 •
edited
Loading

Associated engine changes in flutter/engine#19038

stuartmorgan-g
stuartmorgan-g reviewed Jun 15, 2020
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin bullet-proofing probably isn't necessary (someone running a custom headless runner shouldn't register plugins that need the view), but there's not much complexity to it so it's probably worth adding regardless.

@stuartmorgan-g stuartmorgan-g merged commit bc32317 into google:master Jun 16, 2020
@robert-ancell robert-ancell deleted the gtk-headless-mode branch June 17, 2020 03:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-ancell @stuartmorgan-g @stuartmorgan