Skip to content

Split FlApplication into its own module. #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions testbed/gtk/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ pkg_check_modules(GTK REQUIRED IMPORTED_TARGET gtk+-3.0)
# Application build
add_executable(${BINARY_NAME}
"main.cc"
"fl_application.cc"
"window_configuration.cc"
"${FLUTTER_MANAGED_DIR}/gtk_plugin_registrant.cc"
)
Expand Down
42 changes: 42 additions & 0 deletions testbed/gtk/fl_application.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
#include "fl_application.h"

#include <flutter_linux/flutter_linux.h>

#include "flutter/gtk_plugin_registrant.h"
#include "window_configuration.h"

struct _FlApplication {
GtkApplication parent_instance;
};

G_DEFINE_TYPE(FlApplication, fl_application, GTK_TYPE_APPLICATION)

// Implements GApplication::activate.
static void fl_application_activate(GApplication* application) {
GtkWindow* window =
GTK_WINDOW(gtk_application_window_new(GTK_APPLICATION(application)));
gtk_widget_show(GTK_WIDGET(window));
gtk_widget_set_size_request(GTK_WIDGET(window), kFlutterWindowWidth,
kFlutterWindowHeight);
gtk_window_set_title(window, kFlutterWindowTitle);

g_autoptr(FlDartProject) project = fl_dart_project_new();

FlView* view = fl_view_new(project);
gtk_widget_show(GTK_WIDGET(view));
gtk_container_add(GTK_CONTAINER(window), GTK_WIDGET(view));

fl_register_plugins(FL_PLUGIN_REGISTRY(view));

gtk_widget_grab_focus(GTK_WIDGET(view));
}

static void fl_application_class_init(FlApplicationClass* klass) {
G_APPLICATION_CLASS(klass)->activate = fl_application_activate;
}

static void fl_application_init(FlApplication* self) {}

FlApplication* fl_application_new() {
return FL_APPLICATION(g_object_new(fl_application_get_type(), nullptr));
}
18 changes: 18 additions & 0 deletions testbed/gtk/fl_application.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#ifndef FLUTTER_FL_APPLICATION_H_
#define FLUTTER_FL_APPLICATION_H_

#include <gtk/gtk.h>

G_DECLARE_FINAL_TYPE(FlApplication, fl_application, FL, APPLICATION,
GtkApplication)

/**
* fl_application_new:
*
* Creates a new Flutter application.
*
* Returns: a new #FlApplication.
*/
FlApplication* fl_application_new();

#endif // FLUTTER_FL_APPLICATION_H_
45 changes: 1 addition & 44 deletions testbed/gtk/main.cc
Original file line number Diff line number Diff line change
@@ -1,47 +1,4 @@
#include <flutter_linux/flutter_linux.h>
#include <gtk/gtk.h>

#include "flutter/gtk_plugin_registrant.h"
#include "window_configuration.h"

G_DECLARE_FINAL_TYPE(FlApplication, fl_application, FL, APPLICATION,
GtkApplication)

struct _FlApplication {
GtkApplication parent_instance;
};

G_DEFINE_TYPE(FlApplication, fl_application, GTK_TYPE_APPLICATION)

// Implements GApplication::activate.
static void fl_application_activate(GApplication* application) {
GtkWindow* window =
GTK_WINDOW(gtk_application_window_new(GTK_APPLICATION(application)));
gtk_widget_show(GTK_WIDGET(window));
gtk_widget_set_size_request(GTK_WIDGET(window), kFlutterWindowWidth,
kFlutterWindowHeight);
gtk_window_set_title(window, kFlutterWindowTitle);

g_autoptr(FlDartProject) project = fl_dart_project_new();

FlView* view = fl_view_new(project);
gtk_widget_show(GTK_WIDGET(view));
gtk_container_add(GTK_CONTAINER(window), GTK_WIDGET(view));

fl_register_plugins(FL_PLUGIN_REGISTRY(view));

gtk_widget_grab_focus(GTK_WIDGET(view));
}

static void fl_application_class_init(FlApplicationClass* klass) {
G_APPLICATION_CLASS(klass)->activate = fl_application_activate;
}

static void fl_application_init(FlApplication* self) {}

static FlApplication* fl_application_new() {
return FL_APPLICATION(g_object_new(fl_application_get_type(), nullptr));
}
#include "fl_application.h"

int main(int argc, char** argv) {
g_autoptr(FlApplication) app = fl_application_new();
Expand Down