Remove launch call on FLEViewController #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this is on top of 453 so you should only look at the last commit, not the whole diff. I'll land 453 and then rebase this before landing it, but I wanted to post both sides of this change at the same time, and 453 can't land until the engine rolls to pick up the other side of that change. |
franciscojma86
approved these changes
Jul 10, 2019
Updates macOS Runners for flutter/engine#9750 Projects are now configured via init, and there is no explicit launch command on a view controller.
stuartmorgan-g
force-pushed
the
viewcontroller-init-launch-changes
branch
from
8ca41ad to
145e10e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates macOS Runners for
flutter/engine#9750
Projects are now configured via init, and there is no explicit launch
command on a view controller.