Skip to content

Improve Variable.{get,set}_metadata #4985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2025
Merged

Improve Variable.{get,set}_metadata #4985

merged 1 commit into from
Oct 1, 2025

Conversation

@cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Sep 26, 2025 •
edited
Loading

What does this PR do?

  • Adds a few more options to Variable.{get,set}_metadata like support for default value and simple string setter signature.
  • Adds automatic empty slots for new Variable subtypes to forbid unknown attributes to Variable instances.

@cgarciae cgarciae force-pushed the no-setattr-metadata branch from 777a8e1 to c23304d Compare October 1, 2025 22:15
@cgarciae cgarciae changed the title Variable.__setattr__ no longer sets metadata Improve Variable.{get,set}_metadata Oct 1, 2025
@copybara-service copybara-service bot merged commit 6080725 into main Oct 1, 2025
18 checks passed
@copybara-service copybara-service bot deleted the no-setattr-metadata branch October 1, 2025 23:35
@liudangyi liudangyi mentioned this pull request Nov 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pull ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cgarciae