-
Notifications
You must be signed in to change notification settings - Fork 759
Move iter_children and iter_modules to functions #4961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vfdev-5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I left few comments for improvements.
Apply the comments to both nnx.iter_modules and nnx.iter_children.
Please also expose new methods in the docs_nnx: https://github.com/google/flax/blob/main/docs_nnx/api_reference/flax.nnx/module.rst
and also in __init__ to be addressable as nnx.*.
However, we should confirm the submodule where to put these methods.
@cgarciae flax/nnx/module.py is ok or in graph.py ?
83cdec2 to
4dfafeb
Compare
|
@vfdev-5 I think they should remain in |
vfdev-5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @samanklesaria
Closes #4943