Skip to content

Exposed OptState in nnx module #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Exposed OptState in nnx module #4788

merged 1 commit into from
Jun 24, 2025

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Jun 24, 2025

What does this PR do?

According to an internal discussion about Optimizer state serialization:

optimizer_state = nnx.state(optimizer, nnx.optimizer.OptState)

we should simplify this to nnx.OptState

In this PR a minor change, exposing nnx.optimizer.OptState as nnx.OptState:

>>> import flax.nnx as nnx
>>> nnx.OptState
<class 'flax.nnx.training.optimizer.OptState'>

@vfdev-5 vfdev-5 requested a review from cgarciae June 24, 2025 07:52
@copybara-service copybara-service bot merged commit 0b9bb4e into main Jun 24, 2025
19 checks passed
@copybara-service copybara-service bot deleted the add branch June 24, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgarciae cgarciae cgarciae approved these changes

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vfdev-5 @cgarciae