Skip to content

[Dart] Fix struct vector ordering in pack function #8747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

[Dart] Fix struct vector ordering in pack function #8747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dart/test/monster_test_my_game.example_generated.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1578,7 +1578,7 @@ class MonsterT implements fb.Packable {
final int? testOffset = test?.pack(fbBuilder);
int? test4Offset;
if (test4 != null) {
for (var e in test4!) {
for (var e in test4!.reversed) {
e.pack(fbBuilder);
}
test4Offset = fbBuilder.endStructVector(test4!.length);
Expand Down Expand Up @@ -1608,7 +1608,7 @@ class MonsterT implements fb.Packable {
);
int? testarrayofsortedstructOffset;
if (testarrayofsortedstruct != null) {
for (var e in testarrayofsortedstruct!) {
for (var e in testarrayofsortedstruct!.reversed) {
e.pack(fbBuilder);
}
testarrayofsortedstructOffset = fbBuilder.endStructVector(
Expand All @@ -1620,7 +1620,7 @@ class MonsterT implements fb.Packable {
: fbBuilder.writeListUint8(flex!);
int? test5Offset;
if (test5 != null) {
for (var e in test5!) {
for (var e in test5!.reversed) {
e.pack(fbBuilder);
}
test5Offset = fbBuilder.endStructVector(test5!.length);
Expand Down
4 changes: 2 additions & 2 deletions src/idl_gen_dart.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,8 +1025,8 @@ class DartGenerator : public BaseGenerator {
field.value.type.struct_def->fixed) {
code += " int? " + offset_name + ";\n";
code += " if (" + field_name + " != null) {\n";
code +=
" for (var e in " + field_name + "!) { e.pack(fbBuilder); }\n";
code += " for (var e in " + field_name +
"!.reversed) { e.pack(fbBuilder); }\n";
code += " " + namer_.Variable(field) +
"Offset = fbBuilder.endStructVector(" + field_name +
"!.length);\n";
Expand Down
6 changes: 3 additions & 3 deletions tests/monster_test_my_game.example_generated.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,7 +1412,7 @@ class MonsterT implements fb.Packable {
final int? testOffset = test?.pack(fbBuilder);
int? test4Offset;
if (test4 != null) {
for (var e in test4!) { e.pack(fbBuilder); }
for (var e in test4!.reversed) { e.pack(fbBuilder); }
test4Offset = fbBuilder.endStructVector(test4!.length);
}
final int? testarrayofstringOffset = testarrayofstring == null ? null
Expand All @@ -1429,14 +1429,14 @@ class MonsterT implements fb.Packable {
: fbBuilder.writeList(testarrayofstring2!.map(fbBuilder.writeString).toList());
int? testarrayofsortedstructOffset;
if (testarrayofsortedstruct != null) {
for (var e in testarrayofsortedstruct!) { e.pack(fbBuilder); }
for (var e in testarrayofsortedstruct!.reversed) { e.pack(fbBuilder); }
testarrayofsortedstructOffset = fbBuilder.endStructVector(testarrayofsortedstruct!.length);
}
final int? flexOffset = flex == null ? null
: fbBuilder.writeListUint8(flex!);
int? test5Offset;
if (test5 != null) {
for (var e in test5!) { e.pack(fbBuilder); }
for (var e in test5!.reversed) { e.pack(fbBuilder); }
test5Offset = fbBuilder.endStructVector(test5!.length);
}
final int? vectorOfLongsOffset = vectorOfLongs == null ? null
Expand Down
Loading