[Swift] Fixes forward offset verifiable objects within arrays & fixes failing tests #8135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustiikhalil
changed the title
mustiikhalil
force-pushed
the
fix-verifier-failing
branch
2 times, most recently
from
17cb2fa
to
07f3b7c
Compare
mustiikhalil
changed the title
Fixes failing tests & removes XCTestsManifests
mustiikhalil
force-pushed
the
fix-verifier-failing
branch
from
07f3b7c
to
84637d4
Compare
dbaileychess
approved these changes
Nov 18, 2023
candysonya
pushed a commit
to candysonya/flatbuffers
that referenced
this pull request
Jan 8, 2024
Fixes failing tests & removes XCTestsManifests Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
Fixes failing tests & removes XCTestsManifests Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
Fixes failing tests & removes XCTestsManifests Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following was discovered after a discussion over in the following PR #8134. We didn't create the proper value for the for loop clamping.