Remove msvc pragma warning disable C4351 as it is undocumented #8124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaileychess
approved these changes
Nov 18, 2023
candysonya
pushed a commit
to candysonya/flatbuffers
that referenced
this pull request
Jan 8, 2024
Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC warning C4351 was introduced to warn users about a now-corrected new behavior of the visual studio compiler. It was documented here: https://learn.microsoft.com/en-us/previous-versions/1ywe7hcy(v=vs.140)
I could not find any up-to-date official documentation about the warning. It seems like Microsoft just removed it from its compilers. When I try to use flatbuffers with the vs2019 MSVC compiler (version 16.11.2+f32259642), I get the following warning message:
C:\.conan\c6697b\1\include\flatbuffers/base.h(355,11): warning C4619: #pragma warning: there is no warning number '4351' [C:\[...].vcxproj]With warnings as errors enabled, this prevents me from compiling anything that includes
flatbuffers/base.h.This PR removes the pragma directive as the disabled warning is not documented any longer.
(the directive was introduced in #5938)