Fix //tests/ts:bazel_repository_test #7952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was not actually invoking the bazel that was downloaded with the `http_file` rule. I failed to add `executable = True` to the `http_file` call. This caused the test to ignore that bazel binary and went to the next one on the system. This patch fixes the issue by adding the missing attribute. Also, this patch changes the check in the test to make sure that the downloaded file is indeed executable.
philsc
force-pushed
the
unreviewed/phil/fix-7937
branch
from
de0d322
to
03b1b0e
Compare
dbaileychess
approved these changes
May 11, 2023
sssooonnnggg
pushed a commit
to sssooonnnggg/flatbuffers
that referenced
this pull request
May 12, 2023
The test was not actually invoking the bazel that was downloaded with the `http_file` rule. I failed to add `executable = True` to the `http_file` call. This caused the test to ignore that bazel binary and went to the next one on the system. This patch fixes the issue by adding the missing attribute. Also, this patch changes the check in the test to make sure that the downloaded file is indeed executable.
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
The test was not actually invoking the bazel that was downloaded with the `http_file` rule. I failed to add `executable = True` to the `http_file` call. This caused the test to ignore that bazel binary and went to the next one on the system. This patch fixes the issue by adding the missing attribute. Also, this patch changes the check in the test to make sure that the downloaded file is indeed executable.
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
The test was not actually invoking the bazel that was downloaded with the `http_file` rule. I failed to add `executable = True` to the `http_file` call. This caused the test to ignore that bazel binary and went to the next one on the system. This patch fixes the issue by adding the missing attribute. Also, this patch changes the check in the test to make sure that the downloaded file is indeed executable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was not actually invoking the bazel that was downloaded with
the
http_filerule. I failed to addexecutable = Trueto thehttp_filecall. This caused the test to ignore that bazel binary andwent to the next one on the system.
This patch fixes the issue by adding the missing attribute. Also, this
patch changes the check in the test to make sure that the downloaded
file is indeed executable.
Fixes #7937