Support file_identifier in Go #7904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c++
codegen
jdemeyer
force-pushed
the
go-file-identifier
branch
from
30a8751
to
1fb83e0
Compare
jdemeyer
force-pushed
the
go-file-identifier
branch
from
1fb83e0
to
1ec0d13
Compare
le-michael
requested changes
Apr 14, 2023
|
LGTM. I'll defer to @dbaileychess for the final approval. |
le-michael
approved these changes
Apr 16, 2023
dbaileychess
approved these changes
Apr 26, 2023
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7901
I'm not 100% sure about the type to use for file identifiers. The existing method
builder.FinishWithFileIdentifieruses a[]byte. But I felt like astringis more appropriate (for one, because it can be aconstthen), so the new functionality in this PR usesstring. But I'm open to change this if needed. Another option would be a fixed-size array[4]byte.