Expand wildcard imports in the generated Kotlin files. #7757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested: ``` $ cmake -G "Unix Makefiles" && make && ./flattests ... [ 99%] Linking CXX executable flatsamplebinary [100%] Built target flatsamplebinary ALL TESTS PASSED ```
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
c++
codegen
|
HI @anton-bobukh! What is the goal here? Is there any disadvantage on the wildcard? |
|
@paulovap We have stricter restrictions on wildcard imports within Google, so these generated files get flagged and require additional review. So its often better to just be explicit in what you require. |
paulovap
approved these changes
Jan 5, 2023
sunwen18
pushed a commit
to sunwen18/flatbuffers
that referenced
this pull request
Jan 9, 2023
Tested: ``` $ cmake -G "Unix Makefiles" && make && ./flattests ... [ 99%] Linking CXX executable flatsamplebinary [100%] Built target flatsamplebinary ALL TESTS PASSED ``` Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested: