Fix go.mod name #7756
Merged
Fix go.mod name #7756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dbaileychess
approved these changes
Jan 4, 2023
frc971-automation
pushed a commit
to frc971/971-Robot-Code
that referenced
this pull request
Jan 8, 2023
I don't understand exactly what's going on with the Go package mirroring. For some reason gazelle doesn't want to mirror the flatbuffers package. Possibly because we already have it defined in our workspace. Not sure. There's some magic somewhere that I don't have insight into. Regardless, we should explicitly point gazelle at our vendored version of flatbuffers. That's what this patch accomplishes. I think this was caused by google/flatbuffers#7756 or google/flatbuffers#7720, but I'm not sure. At least the timing matches. This patch effectively reverts Ibd850b77987625d359a38bf53d7db4ae9bc77dc2. Signed-off-by: Philipp Schrader <philipp.schrader@gmail.com> Change-Id: I489d2150811bd00ab810a3038bbac2d0dc74ff6d
sunwen18
pushed a commit
to sunwen18/flatbuffers
that referenced
this pull request
Jan 9, 2023
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes go.mod naming issue introduced by #7720.
Module name should be
github.com/google/flatbuffers/gonotgithub.com/google/flatbuffers.https://pkg.go.dev/github.com/google/flatbuffers/go
https://google.github.io/flatbuffers/flatbuffers_guide_use_go.html