-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Fix clang -Wnewline-eof
warning
#7711
Conversation
Thanks, can you add this flag to the list here as well? https://github.com/google/flatbuffers/blob/master/CMakeLists.txt#L406 |
075c512
to
ef25cde
Compare
ef25cde
to
93f5719
Compare
@dbaileychess This pull request is rebased to the latest master branch. |
Thanks! |
* Fix clang -Wnewline-eof warning * Enable -Wnewline-eof warning Co-authored-by: Derek Bailey <derekbailey@google.com>
* Fix clang -Wnewline-eof warning * Enable -Wnewline-eof warning Co-authored-by: Derek Bailey <derekbailey@google.com>
* Fix clang -Wnewline-eof warning * Enable -Wnewline-eof warning Co-authored-by: Derek Bailey <derekbailey@google.com>
Building a flatc-generated C++ header with Clang 14 and
-Wnewline-eof
option produces the following warnings generated by the inclusion of several header files<include/flatbuffers/*.h>
:This PR adds a newline at eof to avoid the warnings.