Closed
Conversation
Yosym12
reviewed
Dec 1, 2022
Closed
Contributor
|
@dbaileychess I see this PR closed and I'm not sure if it is still relevant. If yes, I would like to continue this work in a new PR. Right now, I am facing some conflicts when using generated php files, with reserved php keywords. Also, I would want to bring into php prefixed size buffers, clear method, create bytes vector, and possibly improve string serialisation speed using substr_replace instead of the current for-loop (at the cost of higher memory usage and garbage collection pressure when performing many serialisations). I guess, the later one needs to be decided. Thanks! |
razvanalex
added a commit
to razvanalex/flatbuffers
that referenced
this pull request
Dec 22, 2023
Some languages use the IDL interface to generate the method/varible/etc names. This commit adds the IDL namer to php, basically continuing the workf from PR google#7491. Now, each method uses namer_.Method, while the legacy stuff is kept for backwards compatibility. At the moment, PHP is the only language that uses the case sensitive check when generating the names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7142