[Feature] Checks for Nullable strings #6050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krojew do you mind reviewing the JS code? |
krojew
approved these changes
Jul 26, 2020
aardappel
approved these changes
Jul 27, 2020
mustiikhalil
pushed a commit
to mustiikhalil/flatbuffers
that referenced
this pull request
Jul 31, 2020
* Allows null strings in createString method c# * Adds nullable strings to JS and swift * Changes js checks * Fixes typo
ivannp
pushed a commit
to ivannp/flatbuffers
that referenced
this pull request
Oct 2, 2020
* Allows null strings in createString method c# * Adds nullable strings to JS and swift * Changes js checks * Fixes typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR would allow the builder to check if the strings are valid before encoding them into the buffer in the following languages:
C#
JS
Swift
Close #6031