-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Swift] Optional Scalars Preparation #6028
Conversation
0266ae0
to
2c64d45
Compare
In languages where a string can legally be Not sure about the optional ints, maybe wait until the first |
Yeah, that makes complete sense, JavaScript, maybe also csharp, and go. After all this is a nice to have. Yes, this is just a draft for now until flatc supports it, so we can simple write the generator code for swift later on. Which would be cpp related and not swift. |
… method + disables linters in generated code
1f27700
to
b464e1a
Compare
@aardappel I've moved this to ready to merge incase we would want to merge this PR for now, and then start working on the cpp generator to work with optional values |
Ok, you can merge this now. Though would be good in the future to keep unrelated topics in separate PRs (small unrelated fixes / improvements are ok, but larger ones in their own PR I'd say). |
Noted |
* Perpares swift to take optional scalars + adds optional string helper method + disables linters in generated code * Small fix for generated code * Update grpc support to alpha 17 for swift
* Perpares swift to take optional scalars + adds optional string helper method + disables linters in generated code * Small fix for generated code * Update grpc support to alpha 17 for swift
The following PR prepares the swift implementation to take optional scalars as a parameter. it adds two functions that swift users would find useful.
1- Optional scalars #6014
2- Optional strings
3- updates the version to
0.7.0
since adding optionals is a major update.4- disable linters in the generated code
@aardappel what do you think? would an optional string helper function be useful in other languages too? should I add it?