Skip to content

CI test with memory leak #5283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2019
Merged

CI test with memory leak #5283

merged 1 commit into from
Apr 11, 2019

Conversation

vglavnyy
Copy link
Contributor

@vglavnyy vglavnyy commented Apr 9, 2019

This is test PR to check AppVeyor and Travis CI (#5265).

@vglavnyy
Copy link
Contributor Author

vglavnyy commented Apr 9, 2019

All MSVC builds have detected the memory leak (see logs).
It's desirable to add a modern compiler to Travis CI (Clang 8 or GCC 8, better both).

@aardappel
Copy link
Collaborator

I wouldn't mind adding a more modern compiler, as long as we can also keep an older compiler.

Can you make a small fix for just this leak?

@aardappel aardappel merged commit 2bd4a27 into google:master Apr 11, 2019
@vglavnyy vglavnyy mentioned this pull request Apr 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vglavnyy @aardappel