This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Open
Conversation
kirussel
force-pushed
the
bstg_flist_import_42
branch
from
397fbe8 to
aa1b511
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adventure started when I passed a string with newlines to
bstg_flist_import(). The newlines caused the parse to fail with no clues to stderr about what went wrong.Bugs I fixed in
bstg_flist_import():""and" "the same way -- both as an errorwarnx()to print useful error messagesbstg_flist_import()more than once in the unit testsprovegives an warning (You named your test '1'. You shouldn't use numbers for your test names.) if tests are named with just a number -- I rename tests named like"1"