fix: Resolve a TSan warning for ShaderCompilerService#9792
Open
fix: Resolve a TSan warning for ShaderCompilerService#9792
Conversation
When the backend thread checks the availability of the token, it directly accesses `gl.program`, which caused a TSan warning. BUGS=[491819760]
pixelflinger
approved these changes
Mar 11, 2026
Collaborator
pixelflinger
left a comment
pixelflinger
left a comment
There was a problem hiding this comment.
LGTM, but I think the code could have a few more comments
| return;// It's ready. | ||
| if (mMode == Mode::THREAD_POOL) { | ||
| if (token->isReady()) { | ||
| return; |
Collaborator
There was a problem hiding this comment.
shouldn't we also check or assert that token->gl.program is not zero?
| return false; | ||
| } | ||
| token->retrievedFromBlobCache = true; | ||
| token->signal(); |
Collaborator
There was a problem hiding this comment.
mayeb add a comment that this acts as a "release" for token->gl.program
| if (token->gl.program) { | ||
| return;// It's ready. | ||
| if (mMode == Mode::THREAD_POOL) { | ||
| if (token->isReady()) { |
Collaborator
There was a problem hiding this comment.
maybe add a comment that this acts as "acquire" for token->gl.program
poweifeng
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the backend thread checks the availability of the token, it directly accesses
gl.program, which caused a TSan warning.BUGS=[491819760]