gltfio: Allow compile-time override of GLTFIO_USE_FILESYSTEM#9733
Open
nmfisher wants to merge 1 commit intogoogle:mainfrom
Open
gltfio: Allow compile-time override of GLTFIO_USE_FILESYSTEM#9733nmfisher wants to merge 1 commit intogoogle:mainfrom
nmfisher wants to merge 1 commit intogoogle:mainfrom
Conversation
nmfisher
force-pushed
the
gltfio-filesystem-override
branch
from
652c6b8 to
cd3d01f
Compare
nmfisher
force-pushed
the
gltfio-filesystem-override
branch
from
cd3d01f to
65b27cd
Compare
pixelflinger
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GLTFIO_USE_FILESYSTEMis hardcoded inFFilamentAsset.hdepending on target platform (0for emscripten/Android/iOS,1for others). This isn't flexible, consumers may want to disable the filesystem to force all gltf resources to be loaded from in-memory buffers (e.g. running on a sandboxed macos app with no filesystem access). This doesn't work under the current implementation becauseloadCgltfBufferswill always try to load from the filesystem whenGLTFIO_USE_FILESYSTEM=1.This PR adds a
#ifndef GLTFIO_USE_FILESYSTEMcheck before definingGLTFIO_USE_FILESYSTEMso downstream consumers can decide at build time whether this is enabled or disabled by adding a CMake flag-DGLTFIO_USE_FILESYSTEM=0or-DGLTFIO_USE_FILESYSTEM=1.