Fix translucent objects are pickable when skybox is disabled#9688
Open
show50726 wants to merge 1 commit intogoogle:mainfrom
Open
Fix translucent objects are pickable when skybox is disabled#9688show50726 wants to merge 1 commit intogoogle:mainfrom
show50726 wants to merge 1 commit intogoogle:mainfrom
Conversation
bejado
approved these changes
Feb 6, 2026
Member
bejado
left a comment
bejado
left a comment
There was a problem hiding this comment.
LGTM, but Mathias should definitely review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9687
Previously, we only cancel the depth write of translucent objects in structure pass, the commands still happened, so the ID of translucent objects were still written to the picking buffer (but without updating the depth buffer).
It didn't cause problem when the skybox is enabled because the depth of skybox is always drawn at last, so the translucent objects' ID will eventually be overriden with the skybox one and hence becomes unpickable.
However, when the skybox is disabled, the translucent objects' ID remains on the buffer so we would be able to pick it.
We solve this problem by cancelling the translucent objects' commands completely when they are filtered out.