Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gltfio: use tangent space mesh #7566

Closed
wants to merge 2 commits into from
Closed

gltfio: use tangent space mesh #7566

wants to merge 2 commits into from

Commits on Feb 22, 2024

  1. gltfio: use tangent space mesh 

     - Fix missing attributes in TangentSpaceMesh
 - Fix missing reference in MikktspaceImpl.cpp
 - Add gltfio/src/extended to implement an alternate loader for
   primitives. This is largely based on the implementation in
   AssetLoader/ResourceLoader
 - Pull common methods between the two implementations into a
   utility namespace.
 - Switch gltf_viewer to use new gltf loader (extended loader).
 - Able to correctly produce flat shading from gltf that only have
   vertex positions and indices.
 - Able to run mikktspace to generate tangent spaces as per gltf
   spec
 - Note that java/webgl samples have not been ported to this
   framework due to difficulty in maintaining interaction between
   AssetLoader/ResourceLoader

Fixes #7444; Fixes #6358
    @poweifeng
    poweifeng committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    872d243 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pf/gltfio-tangent-space-mesh

    @poweifeng
    poweifeng authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    e2db352 View commit details
    Browse the repository at this point in the history