engine: support setDepthFunc for MaterialInstance #7004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bejado
approved these changes
Jul 27, 2023
poweifeng
reviewed
Jul 27, 2023
| @@ -101,6 +101,8 @@ class FMaterialInstance : public MaterialInstance { | |||
|
|
|||
| backend::RasterState::DepthFunc getDepthFunc() const noexcept { return mDepthFunc; } | |||
|
|
|||
| void setDepthFunc(backend::RasterState::DepthFunc depthFunc) noexcept { mDepthFunc = depthFunc; } | |||
There was a problem hiding this comment.
longer than 100 chars I think
romainguy
reviewed
Jul 27, 2023
poweifeng
approved these changes
Jul 27, 2023
samples/depthtesting.cpp
Outdated
| auto gui = [&app](Engine* engine, View* view) { | ||
| int depthFuncSelection = (int) app.depthFunc; | ||
| ImGui::Combo("Depth Function", &depthFuncSelection, | ||
| "Less or equal\0Greater or equal\0Strictly less than\0Strictly greater than\0Equal\0Not equal\0Always\0Never\0\0"); |
mackong
force-pushed
the
feat/expose-set-depthfunc
branch
2 times, most recently
from
534a645
to
6ee5a14
Compare
mackong
force-pushed
the
feat/expose-set-depthfunc
branch
from
6ee5a14
to
bfef186
Compare
pixelflinger
approved these changes
Jul 31, 2023
plepers
pushed a commit
to plepers/filament
that referenced
this pull request
Dec 9, 2023
Co-authored-by: Mathias Agopian <mathias@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.