-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geometry: Add TangentSpaceMesh class outline #6476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please add a release note line to RELEASE_NOTES.md. If this PR does not warrant a release note, add the 'internal' label to this PR. |
poweifeng
force-pushed
the
pf/tangent-space-mesh-1
branch
from
January 19, 2023 22:11
ff95d4f
to
bc3faf8
Compare
poweifeng
force-pushed
the
pf/tangent-space-mesh-1
branch
2 times, most recently
from
January 19, 2023 22:26
976d8e1
to
0a15a23
Compare
- Defined class with documentation in comments - Implemented algorithm selection - No actual algorithms written yet Part of #6358
poweifeng
force-pushed
the
pf/tangent-space-mesh-1
branch
from
January 19, 2023 22:27
0a15a23
to
05b001d
Compare
I'm breaking the SurfaceOrientation successor down into multiple commits. This is the first. |
bejado
requested changes
Jan 23, 2023
poweifeng
force-pushed
the
pf/tangent-space-mesh-1
branch
from
January 23, 2023 20:48
228a2ef
to
a07506b
Compare
bejado
approved these changes
Jan 23, 2023
pixelflinger
requested changes
Jan 23, 2023
pixelflinger
approved these changes
Jan 26, 2023
Co-authored-by: Mathias Agopian <mathias@google.com>
Co-authored-by: Mathias Agopian <mathias@google.com>
plepers
pushed a commit
to plepers/filament
that referenced
this pull request
Dec 9, 2023
- Defined class with documentation in comments - Implemented algorithm selection - No actual algorithms written yet Part of google#6358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6358