Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geometry: Add TangentSpaceMesh class outline #6476

Merged
merged 11 commits into from
Jan 26, 2023
Merged

Conversation

poweifeng
Copy link
Contributor

@poweifeng poweifeng commented Jan 19, 2023

  • Defined class with documentation in comments
  • Implemented algorithm selection
  • No actual algorithms written yet

Part of #6358

@github-actions
Copy link

Please add a release note line to RELEASE_NOTES.md. If this PR does not warrant a release note, add the 'internal' label to this PR.

@poweifeng poweifeng added the internal Issue/PR does not affect clients label Jan 19, 2023
@poweifeng poweifeng force-pushed the pf/tangent-space-mesh-1 branch 2 times, most recently from 976d8e1 to 0a15a23 Compare January 19, 2023 22:26
 - Defined class with documentation in comments
 - Implemented algorithm selection
 - No actual algorithms written yet

Part of #6358
@poweifeng
Copy link
Contributor Author

I'm breaking the SurfaceOrientation successor down into multiple commits. This is the first.
Please take a look. Thank you!

libs/geometry/include/geometry/TangentSpaceMesh.h Outdated Show resolved Hide resolved
libs/geometry/include/geometry/TangentSpaceMesh.h Outdated Show resolved Hide resolved
libs/geometry/include/geometry/TangentSpaceMesh.h Outdated Show resolved Hide resolved
libs/geometry/src/TangentSpaceMesh.cpp Outdated Show resolved Hide resolved
libs/geometry/include/geometry/TangentSpaceMesh.h Outdated Show resolved Hide resolved
libs/geometry/include/geometry/TangentSpaceMesh.h Outdated Show resolved Hide resolved
libs/geometry/include/geometry/TangentSpaceMesh.h Outdated Show resolved Hide resolved
libs/geometry/include/geometry/TangentSpaceMesh.h Outdated Show resolved Hide resolved
libs/geometry/include/geometry/TangentSpaceMesh.h Outdated Show resolved Hide resolved
libs/geometry/include/geometry/TangentSpaceMesh.h Outdated Show resolved Hide resolved
libs/geometry/include/geometry/TangentSpaceMesh.h Outdated Show resolved Hide resolved
libs/geometry/include/geometry/TangentSpaceMesh.h Outdated Show resolved Hide resolved
libs/geometry/src/TangentSpaceMesh.cpp Outdated Show resolved Hide resolved
libs/geometry/include/geometry/TangentSpaceMesh.h Outdated Show resolved Hide resolved
libs/geometry/include/geometry/TangentSpaceMesh.h Outdated Show resolved Hide resolved
@poweifeng poweifeng merged commit 45246b6 into main Jan 26, 2023
@poweifeng poweifeng deleted the pf/tangent-space-mesh-1 branch January 26, 2023 22:39
plepers pushed a commit to plepers/filament that referenced this pull request Dec 9, 2023
 - Defined class with documentation in comments
 - Implemented algorithm selection
 - No actual algorithms written yet

Part of google#6358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants