Skip to content

Upgraded test setup to support the latest ESLint version for new npm release. #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MarkusBordihn
Copy link
Member

@MarkusBordihn MarkusBordihn commented Apr 1, 2025

Upgraded test setup to support the latest ESLint version. #75
Added automated tests for configuration validation. #73
Prepared package for npm release. #76
Bumped major version to reflect breaking changes.
Fixed formatting issues in README.md.

Upgraded test setup to support the latest ESLint version.
Added automated tests for configuration validation.
Prepared package for npm release.
Bumped major version to reflect breaking changes.
@MarkusBordihn MarkusBordihn changed the title Fixed formatting issues in README.md. Upgraded test setup to support the latest ESLint version for new npm release. Apr 1, 2025
Copy link
Collaborator

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than pinning via hash I think this is good to go. Thank you!

Pin to a commit hash for automated workflows for recommended security practices.
@MarkusBordihn
Copy link
Member Author

Thank you for the feedback! I've addressed all comments, and the workflow tests on my forked repository completed successfully without any errors:
https://github.com/MarkusBordihn/eslint-config-google/actions/runs/15162705546

@MarkusBordihn
Copy link
Member Author

As soon as this PR is merged (since I do not have permission to merge it myself), I will update the corresponding npm package on npmjs.com.
If any additional review or approval is required before merging, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants