Repository navigation
CompilationTestHelper: group expectations and reported diagnostics per failing line - #6192
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
…r failing line When a line fails its expectation, print the expectation together with the diagnostics reported on that line, or with the source code of the line when no diagnostic was emitted. Diagnostics on passing lines are omitted, and unattached diagnostics are listed in an 'Other diagnostics:' block. Fixes google#6145. Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a
CompilationTestHelpertest fails, expectations and diagnostics were reported in disconnected sections: mismatches listed line numbers and expectation strings, followed byAll errors:which printed every diagnostic emitted during compilation (including passing lines) in a single dump. When a diagnostic was missing on a line, that line's source code did not appear anywhere in the failure message.This change:
Fixes #6145.
Testing