Skip to content

Commit

Permalink
Fix -XepDisableAllWarnings flag when passed on its own
Browse files Browse the repository at this point in the history
Without this change, the flag would not work when passed as the single Error Prone argument.  Not sure how to add a regression test for this, but the fix works locally.

Fixes #3462

FUTURE_COPYBARA_INTEGRATE_REVIEW=#3462 from msridhar:fix-disable-all-warnings 89f2c1d
PiperOrigin-RevId: 481263162
  • Loading branch information
java-team-github-bot authored and Error Prone Team committed Oct 17, 2022
1 parent db6459d commit 1fe7bfd
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ public ScannerSupplier applyOverrides(ErrorProneOptions errorProneOptions) {
&& errorProneOptions.getFlags().isEmpty()
&& !errorProneOptions.isEnableAllChecksAsWarnings()
&& !errorProneOptions.isDropErrorsToWarnings()
&& !errorProneOptions.isDisableAllChecks()) {
&& !errorProneOptions.isDisableAllChecks()
&& !errorProneOptions.isDisableAllWarnings()) {
return this;
}

Expand Down

0 comments on commit 1fe7bfd

Please sign in to comment.