Fix signed/unsigned mismatch in decoder_buffer.h #951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed warning regarding comparing a signed variable `bit` with unsigned `nbits`. The value `nbits` is checked to be less then or equal to 32 in the rows above, which prevents overflow when casting to a signed type.
tomfinegan
changed the title
tomfinegan
approved these changes
Dec 1, 2022
danielgronlund
pushed a commit
to danielgronlund/draco
that referenced
this pull request
Aug 22, 2024
Fixed warning regarding comparing a signed variable `bit` with unsigned `nbits`. The value `nbits` is checked to be less then or equal to 32 in the rows above, which prevents overflow when casting to a signed type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed warning regarding comparing a signed variable
bitwith unsignednbits.The value
nbitsis checked to be less then or equal to 32 in the rows above, which prevents overflow when casting to a signed type.