Disable optimizations for gltf_decoder.cc in MSVC builds. #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not really sure who is to blame, but when TinyGLTF parses testdata/
ondys
approved these changes
Mar 11, 2022
danielgronlund
pushed a commit
to danielgronlund/draco
that referenced
this pull request
Aug 22, 2024
Not really sure who is to blame, but in optimized builds from MSVC gltf_decoder.cc appears to be getting garbage values back from TinyGLTF when it parses the materials for testdata/.../three_meshes_two_materials_one_no_material.gltf Since there's no certainty about whether this is limited to this particular file, just disable optimizations for src/draco/io/gltf_decoder.cc in all MSVC build configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In optimized builds from MSVC draco appears to be getting garbage
values back from TinyGLTF when it parses the materials for
testdata/.../three_meshes_two_materials_one_no_material.gltf
Since there's no certainty about whether this is limited to this
particular file, just disable optimizations for
src/draco/io/gltf_decoder.cc in all MSVC build configurations.