Skip to content

Conversation

atteneder
Copy link
Contributor

Changed the library type from MODULE to STATIC for dracodec_unity IOS only. For other platforms it stays MODULE.

Tested with CMake 3.14.5 (has built-in iOS toolchain)

cmake .. -G Xcode -DCMAKE_SYSTEM_NAME=iOS -DCMAKE_OSX_ARCHITECTURES=armv7\;armv7s\;arm64 -DCMAKE_OSX_DEPLOYMENT_TARGET=10.0 -DCMAKE_XCODE_ATTRIBUTE_ONLY_ACTIVE_ARCH=NO -DBUILD_UNITY_PLUGIN=ON

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@atteneder
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@tomfinegan tomfinegan merged commit 40dc50f into google:master Jul 3, 2019
@atteneder atteneder deleted the unity_ios branch September 15, 2019 07:28
danielgronlund pushed a commit to danielgronlund/draco that referenced this pull request Aug 22, 2024
draco cmake: make unity plugin decoder a static lib on ios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants