Skip to content

Conversation

@heirecka
Copy link
Contributor

CMake >= 4.0.0-rc1 removed compatibility with versions < 3.5 and errors out with such versions passed to cmake_minimum_required(). 3.5.0 has been released 9 years ago, so I'd assume it's available almost everywhere.

CMake >= 4.0.0-rc1 removed compatibility with versions < 3.5 and errors
out with such versions passed to cmake_minimum_required(). 3.5.0 has
been released 9 years ago, so I'd assume it's available almost
everywhere.
Copy link
Collaborator

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@floitsch
Copy link
Collaborator

Thanks!

@floitsch floitsch merged commit 101e1ba into google:master Feb 20, 2025
1 check passed
@heirecka heirecka deleted the raise-required-cmake-version branch February 20, 2025 14:20
@LecrisUT
Copy link

Please consider future-proofing this a bit by adding higher-bound to the CMake policies. The higher bound does not indicate the maximum CMake version allowed to use, instead it is the maximum version that we can bump the the lower-bound to without any degradation. I highly encourage to add 3 CMake builders (lowest policy, highest policy, latest-rc)

@floitsch
Copy link
Collaborator

Please consider future-proofing this a bit by adding higher-bound to the CMake policies. The higher bound does not indicate the maximum CMake version allowed to use, instead it is the maximum version that we can bump the the lower-bound to without any degradation. I highly encourage to add 3 CMake builders (lowest policy, highest policy, latest-rc)

done.

@LecrisUT
Copy link

Thank you, much appreciated ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants