Skip to content

Conversation

@BhavikaSharma
Copy link
Contributor

Two changes:

  1. Add #include <cinttypes> to test/cctest/cctest.h. Without it, on Linux systems, the following error occurs:
note: 'PRId64' is defined in header '<cinttypes>'; did you forget to '#include <cinttypes>'?

and similarly for PRIu64 macro.

  1. double-conversion/bignum-dtoa.h added as a required header in CMakeLists.txt.

double-conversion/bignum-dtoa.cc is added to the library which references this header.

@google-cla
Copy link

google-cla bot commented Feb 11, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@floitsch floitsch merged commit ae0dbfe into google:master Feb 14, 2025
2 checks passed
@floitsch
Copy link
Collaborator

Thanks!
Since the change is small enough, no need to sign the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants