Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set permissions for github workflows #191

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Set permissions for github workflows #191

merged 2 commits into from
Feb 27, 2023

Conversation

joycebrum
Copy link
Contributor

@joycebrum joycebrum commented Feb 27, 2023 •
edited
Loading

Closes #190

Changes

  • Set top level permission as contents: read to both ci.yml and scons.yml

Example of success runs after the changes:

@joycebrum
chore: set ci.yml permissions
ddc2fd4 
Signed-off-by: Joyce <joycebrum@google.com>
@joycebrum
chore: set scons permissions.
334d095 
Signed-off-by: Joyce <joycebrum@google.com>
floitsch
floitsch approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@floitsch floitsch merged commit 6a0224d into google:master Feb 27, 2023
@floitsch
Copy link
Collaborator

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floitsch floitsch floitsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set GitHub Workflow permissions to read only
2 participants
@joycebrum @floitsch