Change breadcrumb and print links to RelPermalink #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Something I've been wanting to fix for quite a while! Were you able to confirm that breadcrumb links encoded as paths rather than full URLs won't break SEO etc.? |
chalin
force-pushed
the
print-and-breadcrumb-permalink-fix
branch
from
0eb08b4
to
33a67d5
Compare
|
TBH I haven't thought that this would impact SEO, just noticed that these
are the only ones with absolute links.
…On Fri, 10 Nov 2023, 21:15 Patrice Chalin, ***@***.***> wrote:
Nice! Something I've been wanting to fix for quite a while!
Fixes:
- #1337 <#1337>
Were you able to confirm that breadcrumb links encoded as paths rather
than full URLs won't break SEO etc.?
—
Reply to this email directly, view it on GitHub
<#1699 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6AU3PZWU7KUTPUVCVXPW3YD2DPNAVCNFSM6AAAAAA6U72JUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWGM3TMNJTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
chalin
force-pushed
the
print-and-breadcrumb-permalink-fix
branch
from
33a67d5
to
b4e8225
Compare
chalin
force-pushed
the
print-and-breadcrumb-permalink-fix
branch
from
b4e8225
to
60676aa
Compare
chalin
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
I'm so glad to see this land, I've been wanting this fixed for a while now. Thanks @fekete-robert!
|
Glad that I could help :) |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breadcrumb links and the print metalink used Permalink instead of RelPermalink, causing them to always link to the full domain referenced in the baseurl of the build. Using relpermalink makes these links work without referencing the baseurl, so they work even in dev environments (for example, when the site is deployed in a local docker container).
Preview, e.g.: https://deploy-preview-1699--docsydocs.netlify.app/docs/get-started/docsy-as-module/