Fix left-nav height and padding

[chalin]

• Fixes Left-nav view height is too short #1657
• Fixes Left-nav formatting issue when sidebar_search_disable #1658
• Fixes Page-meta spacing is off for some pages #1573!
• Supersedes Fix left-nav height and padding using CSS var #1659 by providing a solution that doesn't involve CSS variables
• Adjusts the max-height and top-padding of the td-sidebar-nav depending on
  • The value of .Site.Params.ui.sidebar_search_disable
  • The view width: when the view is md, the sidebar search is always shown, regardless of the value of sidebar_search_disable
• This PR fix works for all six cases:
  (lg, md and sm screens) x (each case of whether sidebar_search_disable is true or not)
• I've also tested with sidebar_menu_foldable set to true
• Preview: https://deploy-preview-1661--docsydocs.netlify.app/docs/adding-content/

Possible followup change to be addressed:

• Sidebar menu reloads to the top and user has to scroll down to find an item #257

---

Screenshots - sidebar_search_disable:true

Notes:

• lg and md screenshots were taken with Firefox
• "After" images are from my local build, where I set sidebar_search_disable:true

View: lg - notice the full sidenav height in the "After" image, and the top padding fix

The "Before" image is from the current production server, but with the search-box manually hidden.

Before	After

View: md - notice the full sidenav height in the "After" image

Before	After

View: sm - no change here (other than a tweak to the bottom padding

Before	After

---

Screenshots - sidebar_search_disable:false

View: lg - notice the full sidenav height in the "After" image

Before	After

View: md - notice the full sidenav height in the "After" image

Before	After

View: sm - no change here (other than a tweak to the bottom padding

Before	After

[chalin]

@yann-soubeyrand - might you be available to review and or comment on this PR? Thanks.

[yann-soubeyrand]

@yann-soubeyrand - might you be available to review and or comment on this PR? Thanks.

Sure, but I’m clearly not a CSS guru: I just fixed two small issues, which took me a lot of time due to my CSS skill! 😆

Anyway, this looks good to me and the visuals are convincing.

[thisisobate]

Works as expected!

[deining]

LGTM.

[chalin]

Thanks all for your feedback.