Skip to content

[BSv5] Drop redundant setting of BS $enable-rounded variable #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chalin merged 1 commit into from
Mar 2, 2023
Merged

[BSv5] Drop redundant setting of BS $enable-rounded variable #1452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions assets/scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,8 @@
/*
// Bootstrap options

Bootstrap variables overrides for theme.
See https://github.com/twbs/bootstrap/pull/23260
*/

// Bootstrap flags. For more, see https://getbootstrap.com/docs/4.0/getting-started/theming/
$enable-gradients: true !default;
$enable-rounded: true !default;
$enable-shadows: true !default;

// Theme flags.

$td-enable-google-fonts: true !default;

// Theme colors

$primary: #30638E !default;
Expand Down Expand Up @@ -59,6 +49,8 @@ $link-hover-decoration: none !default;

// Fonts

$td-enable-google-fonts: true !default;

$google_font_name: "Open Sans" !default;
$google_font_family: "Open+Sans:300,300i,400,400i,700,700i" !default;
$web-font-path: "https://fonts.googleapis.com/css?family=#{$google_font_family}&display=swap";
Expand Down
7 changes: 3 additions & 4 deletions userguide/content/en/docs/adding-content/lookandfeel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ PostCSS (autoprefixing of CSS browser-prefixes) is not enabled when running in s

## Site colors

To easily customize your site's colors, add SCSS variable overrides to
`assets/scss/_variables_project.scss`. A simple example changing the primary and
secondary color to two shades of purple:
To customize your site's colors, add SCSS variable overrides to
`assets/scss/_variables_project.scss`. For example, you can set the primary and
secondary site colors as follows:

```scss
$primary: #390040;
Expand All @@ -43,7 +43,6 @@ The theme has features such as rounded corners and gradient backgrounds enabled

```scss
$enable-gradients: true;
$enable-rounded: true;
$enable-shadows: true;
```

Expand Down